Create notifications #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluix-dev
commented
Sep 17, 2020
fluix-dev
force-pushed
the
notification
branch
from
309369d to
ec622d6
Compare
|
@skyflaren please do the frontend for this. |
fluix-dev
force-pushed
the
notification
branch
2 times, most recently
from
87bc829 to
13290a8
Compare
fluix-dev
commented
Sep 29, 2020
| {% if notif != notifications[0] and notif.notification.linked_item.__str__() != notifications[0].notification.linked_item.__str__() %} | ||
| <hr> | ||
| {% endif %} | ||
| <a class="notification-link font-alt font-bold" href="{{ notif.get_link_url() }}">{{ notif.notification.linked_item.__str__() }}</a> |
There was a problem hiding this comment.
Do you need the __str__()?
Co-authored-by: Steven Guikal <[email protected]>
Co-authored-by: Steven Guikal <[email protected]>
…n.html used to insert hr's
…into notification
dulldesk
reviewed
Oct 1, 2020
| {% endif %} | ||
| <a class="notification-link font-alt font-bold" href="{{ notif.get_link_url() }}">{{ notif.notification.linked_item.__str__() }}</a> | ||
| <span class="font-light">{{ notif.message }}</span><br> | ||
| {% endfor %} |
There was a problem hiding this comment.
Not high priority but could add a message for when there are no notifications.
|
Notifications do not seem to be sorted (and it seems as if you cannot sort by property [as opposed to field]) ¯_(ツ)_/¯ |
You can just sort by |
fluix-dev
commented
Oct 21, 2020
| @@ -122,6 +122,13 @@ footer { | |||
| font-size: 1.5rem; | |||
| } | |||
|
|
|||
| hr{ | |||
There was a problem hiding this comment.
Suggested change
| hr{ | |
| hr { |
| @@ -212,6 +219,14 @@ footer { | |||
| font-weight: 300; | |||
| } | |||
|
|
|||
| .notification-link{ | |||
There was a problem hiding this comment.
Suggested change
| .notification-link{ | |
| .notification-link { |
| color: var(--cirrus-primary); | ||
| } | ||
|
|
||
| .notification-link:hover{ |
There was a problem hiding this comment.
Suggested change
| .notification-link:hover{ | |
| .notification-link:hover { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI for notifications is still necessary.
Fixes #12
Fixes #13